This repository has been archived by the owner on Feb 25, 2020. It is now read-only.
feat: pass current opacity to renderIcon prop in CrossFadeIcon #220
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I was trying to animate a bottom tab bar in the same fashion as the Google Play Store app does. My plan was to use Lottie animations with react-navigation's
createBottomTabBar
.However, the active -> inactive tab animation for say tab A was playing when I was switching between tabs B and C, and I found out that although
CrossFadeIcon
renders both active and inactive tab icons with a different opacity, the Lottie view only accepts opacity as part of its own style and is not affected by its parent opacity.This PR exposes the opacity applied by
CrossFadeIcon
to each tab icon child to fine-tune rendering logic on the client side.Test plan
From the code above, change the behaviour of the Lottie components: