-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Fix flash of unstyled text #240
Conversation
|
✅ Deploy Preview for reactiflux ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the recommended way to add a global stylesheet.
The flash still seems to happen on the initial page load. However it's still way less jarring without the flash in between page transitions, so you can merge this if you want. #242 could fix our remaining issues anyway. |
Thanks. I’ll call it an educated guess 😄 |
Yeah, there will be a short FOUT on initial load but it resolves the jarring flash on every navigation like you say. As it’s such a trivial change, I think we should merge this and look at using Next’s font loaders once we’ve upgraded 👍 |
PR for fixing the flash of unstyled text which is rather jarring and appears to cause a layout shift.
This pull request fixes the FOUT by relocating the font imports from the layout component into the
_app
file.Changes
Layout
component into the_app
file.Layout
component into the_app
file.Notes