Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Universal App support. #552

Merged
merged 18 commits into from
May 27, 2014
Merged

[WIP] Universal App support. #552

merged 18 commits into from
May 27, 2014

Conversation

jlaanstra
Copy link
Member

This PR adds Universal App support to RxUI 6.x.

Changes

  • Switch from Profile78 to Profile259. Profile259 is the new portable profile that should be used for future development. It includes Universal App support. The difference between these profiles is that WCF support is removed from the latter. To switch to this profile I needed to untick Xamarin.iOS and Android, since Xamarin does not yet support this profile in the UI. Manual references work fine.
  • Change all .WinRT projects to include Windows Phone 8.1 support.

Some things that need to be done

@anaisbetts
Copy link
Member

@jlaanstra I don't think we need to switch Splat to Profile259, since its PCLs are only used to compile other PCLs (i.e. Splat.dll doesn't depend on Splat.Portable.dll, it doesn't exist):

image

(ignore visual glitching on loading GIFs, lolWinRT)

The big thing we need to wait on is the Rx stuff, I've got a PR open for that so we can track the new release

@jlaanstra
Copy link
Member Author

@jlaanstra I don't think we need to switch Splat to Profile259, since its PCLs are only used to compile other PCLs

Other PCLs also need to switch to Profile259 such as this PR does. To be able to still reference Splat from the PCL Splat also needs to be at Profile259.

A PR for Splat is on the way :)

@anaisbetts anaisbetts mentioned this pull request Apr 27, 2014
5 tasks
@jlaanstra jlaanstra mentioned this pull request Apr 27, 2014
@jlaanstra
Copy link
Member Author

Reactive Extensions for .NET have been updated but their PCL is not in the folder portable-win8+net45+wp8+wpa81 which means that NuGet will not automatically reference it in our PCL.

I have opened an issue at dotnet/reactive#8

@jlaanstra
Copy link
Member Author

I will submit a new PR with updates to the sample apps and remove that from this PR.

Conflicts:
	Playground-Android/Resources/Resource.designer.cs
	ReactiveUI.Tests/Resources/Resource.designer.cs
@anaisbetts
Copy link
Member

Add new assemblies for Windows Phone 8.1 Silverlight.

I'm not sure we need to do that, unless we're using new WP8.1 Silverlight APIs, no? The 8.0 build should be fine

@anaisbetts
Copy link
Member

@jlaanstra I'm feelin pretty good about this PR, you?

@anaisbetts
Copy link
Member

/cc #589 who is waiting on this

@jlaanstra
Copy link
Member Author

I'm not sure we need to do that, unless we're using new WP8.1 Silverlight APIs, no? The 8.0 build should be fine

Yep, I think is true. Usually they updated the System.Windows.Interactivity assembly to a new version which could cause trouble, but it seems they did not do that this time.

@jlaanstra
Copy link
Member Author

@jlaanstra I'm feelin pretty good about this PR, you?

Me too, but still waiting fior an updated Rx.NET release to include Profile259.

anaisbetts pushed a commit that referenced this pull request May 27, 2014
[WIP] Universal App support.
@anaisbetts anaisbetts merged commit 506e66f into rxui6-master May 27, 2014
@anaisbetts anaisbetts deleted the wpa81 branch May 27, 2014 09:05
@anaisbetts
Copy link
Member

Thanks @jlaanstra!

@lock lock bot locked and limited conversation to collaborators Jun 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants