Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGet all the things! #628

Merged
merged 60 commits into from
May 29, 2014
Merged

NuGet all the things! #628

merged 60 commits into from
May 29, 2014

Conversation

jlaanstra
Copy link
Member

This PR fixes #582 by getting all the packages from NuGet. Locally I have build the RxUI packages except for the mac files to verify that everything works.

What else?

This PR does a number of other things.

Updates to the .nuspec files

The .nuspec files are updated to include the new PCL profiles and the new WPA81 folder.

  • NuGet.exe has been updated to 2.8.2.
  • RxUI.Blend now contains the Blend projects. Putting this in platforms does not make sense since it is only for some Xaml platforms.
  • RxUI.Platforms now references RxUI.Core and RxUI.Blend.
  • Remove the files for RxUI.Mobile.
  • Make sure the .pdb files are tracked.
  • Fix a bug in MakeRelease where a single empty file would not result in an error during the creation of the packages.
  • Kill the WinRT45 identifier and replace it with Win8 for consistency.
  • Fix the Winforms and AndroidSupport packages.

Kill all nuget.targets.

Automatic package restore is way better, so let's use that.

Add missing Testing project

The RxUI.Testing project for Windows 8 was missing and has been added.

Bug fixes to RxUI.Events.

  • The EventBuilder project now also uses packages from NuGet.
  • Events for iOS failed to build with Xamarin 3.0 and possibly earlier.
  • Events for Android failed to build and now references the assemblies in the v1.0 folder.
  • Events for WIndows 8 failed to build because it referenced thee wrong .winmd files.
  • Really reference Android 4.0.3 files.

Small fixes.

  • Make sure all projects output a pdb and xml file in release mode.
  • Fix some configuration mistakes and output folders.
  • Missing link to CommonAssemblyInfo.
  • Fix a reference to a .Net 4 assembly leading to app.config everywhere.

TODO:

  • Only reference RxUI.Blend for the Xaml platforms that support it.
  • Decide if we would update RxUI.Mobile and reference RxUI.Core similar to RxUI-Xaml. It should.
  • Decide if RxUI.Core should have a dependency on Newtonsoft.Json. It shouldn't.
  • In ext is still XamMac.dll and Xamarin.Android.Support.v13.dll. The support lib is also in the reference assemblies folder. Should we use that one? What about XamMac.dll?

@jlaanstra jlaanstra changed the title Nuget all the things NuGet all the things May 29, 2014
@jlaanstra jlaanstra changed the title NuGet all the things NuGet all the things! May 29, 2014
@jlaanstra
Copy link
Member Author

@paulcbetts I think this helps you with #598 :)

@anaisbetts
Copy link
Member

@anaisbetts
Copy link
Member

@anaisbetts
Copy link
Member

Decide if we would update RxUI.Mobile and reference RxUI.Core similar to RxUI-Xaml.

Yep, RxUI.Mobile just becomes a metapackage

Decide if RxUI.Core should have a dependency on Newtonsoft.Json.

Yep. I'm sure people will get so maaaaaaaaadddddd about it, doin' it anyways

In ext is still XamMac.dll and Xamarin.Android.Support.v13.dll. The support lib is also in the reference assemblies folder. Should we use that one? What about XamMac.dll?

I'll fix this stuff up, probably want to just delete XamMac.dll

@jlaanstra
Copy link
Member Author

Yep, RxUI.Mobile just becomes a metapackage

So in the case of RxUI-Platforms I agree, but in this case the functionality of the original RxUI-Mobile just does not exist anymore. Keeping it as a meta-package implies that it still exists but elsewhere.

@anaisbetts
Copy link
Member

So in the case of RxUI-Platforms I agree, but in this case the functionality of the original RxUI-Mobile just does not exist anymore. Keeping it as a meta-package implies that it still exists but elsewhere.

So, if you were using RxUI-Mobile and only had a reference to that, you now should have a reference to RxUI proper on upgrade (Unless you were the one guy who used the location API stuff)

@jlaanstra
Copy link
Member Author

So, if you were using RxUI-Mobile and only had a reference to that, you now should have a reference to RxUI proper on upgrade (Unless you were the one guy who used the location API stuff)

True, but in that case you should rethink large parts of your applications, that simply are not there anymore. I'm not sure what the best option is, but adding the meta package is easy so I will add it.

@jlaanstra
Copy link
Member Author

I've changed the description of the meta packages to indicate that they are no longer needed. Thoughts?

@shiftkey
Copy link
Contributor

Yep. I'm sure people will get so maaaaaaaaadddddd about it, doin' it anyways

Always Be NuGetting

@jlaanstra
Copy link
Member Author

Always Be NuGetting

Definitely agree, but it would be great if there is choice between serializers. Especially since it is suggested to write your own ISuspensionDriver which is the only code that depends on Json.Net as far as I know.

@shiftkey
Copy link
Contributor

@jlaanstra where are we suggesting that?

If users care about the serialization library used, that's one thing.
If users want to control behaviour, that's a different thing (and I think more important).

@shiftkey
Copy link
Contributor

@jlaanstra I'd suggest either 🔥 that comment down if that's not the case, or elaborate on why you should do it, and make it a proper extensibility point...

@anaisbetts
Copy link
Member

Ugh, ok nevermind, let's burn down JSON.NET

@jlaanstra jlaanstra mentioned this pull request May 29, 2014
anaisbetts pushed a commit that referenced this pull request May 29, 2014
@anaisbetts anaisbetts merged commit fb2bf6d into rxui6-master May 29, 2014
@anaisbetts anaisbetts deleted the nuget-all-the-things branch May 29, 2014 22:58
@anaisbetts
Copy link
Member

😍😍😍😍😍😍😍😍😍😍😍😍😍😍😍😍😍😍😍😍😍😍😍😍

@lock lock bot locked and limited conversation to collaborators Jun 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants