-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NuGet all the things! #628
Conversation
@paulcbetts I think this helps you with #598 :) |
Yep, RxUI.Mobile just becomes a metapackage
Yep. I'm sure people will get so maaaaaaaaadddddd about it, doin' it anyways
I'll fix this stuff up, probably want to just delete XamMac.dll |
So in the case of RxUI-Platforms I agree, but in this case the functionality of the original RxUI-Mobile just does not exist anymore. Keeping it as a meta-package implies that it still exists but elsewhere. |
So, if you were using RxUI-Mobile and only had a reference to that, you now should have a reference to RxUI proper on upgrade (Unless you were the one guy who used the location API stuff) |
True, but in that case you should rethink large parts of your applications, that simply are not there anymore. I'm not sure what the best option is, but adding the meta package is easy so I will add it. |
I've changed the description of the meta packages to indicate that they are no longer needed. Thoughts? |
Always Be NuGetting |
Definitely agree, but it would be great if there is choice between serializers. Especially since it is suggested to write your own |
@jlaanstra where are we suggesting that? If users care about the serialization library used, that's one thing. |
@jlaanstra I'd suggest either 🔥 that comment down if that's not the case, or elaborate on why you should do it, and make it a proper extensibility point... |
Ugh, ok nevermind, let's burn down JSON.NET |
😍😍😍😍😍😍😍😍😍😍😍😍😍😍😍😍😍😍😍😍😍😍😍😍 |
This PR fixes #582 by getting all the packages from NuGet. Locally I have build the RxUI packages except for the
mac
files to verify that everything works.What else?
This PR does a number of other things.
Updates to the .nuspec files
The .nuspec files are updated to include the new PCL profiles and the new WPA81 folder.
MakeRelease
where a single empty file would not result in an error during the creation of the packages.WinRT45
identifier and replace it withWin8
for consistency.Kill all nuget.targets.
Automatic package restore is way better, so let's use that.
Add missing Testing project
The RxUI.Testing project for Windows 8 was missing and has been added.
Bug fixes to RxUI.Events.
v1.0
folder.Small fixes.
app.config
everywhere.TODO:
ext
is stillXamMac.dll
andXamarin.Android.Support.v13.dll
. The support lib is also in the reference assemblies folder. Should we use that one? What aboutXamMac.dll
?