perf(Subscription): improve parent management #4526
Merged
+43
−58
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge the
_parent
and_parents
fields on theSubscription
classinto a single
_parentOrParents
field, which can hold eithernull
(in case of no parents), a
Subscription
instance (in case of asingle parent), or an array of
Subscription
s (in case of multipleparents). This not only shrinks the size of
Subscription
(andsubclass) instances, but more importantly reduces the number of
megamorphic property access sites in the hot
Subscription
methods,especially in
unsubscribe()
andadd()
.Also inline the
Subscription#_addParent()
method intoSubscription#add()
, as it's the only call site anyways andthis removes another hot megamorphic
LoadIC
that was only neededto lookup
subscription._addParent
in the call site.Finally remove the
hasErrors
variable fromunsubscribe()
methodand instead just check
errors
variable directly.