Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add zipWith #5249

Merged
merged 3 commits into from
Jan 22, 2020
Merged

add zipWith #5249

merged 3 commits into from
Jan 22, 2020

Conversation

benlesh
Copy link
Member

@benlesh benlesh commented Jan 21, 2020

  • updates tests
  • updates docs
  • updates deprecation messages
  • moves tests for legacy selector behaviors to their own file

@benlesh benlesh requested a review from cartant January 21, 2020 03:04
@cartant cartant mentioned this pull request Jan 22, 2020
Merged
cartant
cartant approved these changes Jan 22, 2020
View reviewed changes
Copy link
Collaborator

@cartant cartant left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a couple of marble diagrams that seem misaligned.

Also, zipWith can likely be made to support N arguments with the types in #5254

spec/operators/zipWith-spec.ts
const e2subs = '^----------------! ';
const e3 = hot('--------h----i----j-------'); // doesn't complete
const e3subs = '^-----------------! ';
const expected = '--------x----y----(z|) '; // e2 buffer empty and signaled complete
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The expected marble diagram seems misaligned.

spec/operators/zipWith-spec.ts

const e1 = hot('---a---b---c---d---|');
const e1subs = '^------------------!';
const expected = '---w---x---y---z---|';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expected misaligned?

@benlesh benlesh merged commit 86b6a27 into ReactiveX:master Jan 22, 2020
kwonoj pushed a commit to kwonoj/rxjs that referenced this pull request Feb 5, 2020
@benlesh @kwonoj
feat(zipWith): add zipWith which is just a rename of zip (ReactiveX#5249
21834ec 
)

* feat(zipWith): add zipWith which is just a rename of zip

- moves tests around to split off legacy behaviors

* chore(zipWith): update tests for run mode

* chore: fix alignments
martinsik pushed a commit to martinsik/rxjs that referenced this pull request Feb 15, 2020
@benlesh
feat(zipWith): add zipWith which is just a rename of zip (ReactiveX#5249
049817b 
)

* feat(zipWith): add zipWith which is just a rename of zip

- moves tests around to split off legacy behaviors

* chore(zipWith): update tests for run mode

* chore: fix alignments
@lock lock bot locked as resolved and limited conversation to collaborators Feb 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cartant cartant cartant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benlesh @cartant