fix(symbol): revert unique symbol in #5874 #6224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartant
reviewed
Apr 13, 2021
src/internal/symbol/observable.ts
Outdated
Comment on lines
1
to
9
| /** Symbol.observable addition */ | ||
| /* Note: This will add Symbol.observable globally for all TypeScript users, | ||
| however, we are no longer polyfilling Symbol.observable */ | ||
| declare global { | ||
| interface SymbolConstructor { | ||
| readonly observable: symbol; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
I don't think we should revert the moving of this declaration, as its being moved solved a problem. See this PR which made the same change to the 6.x branch and the issue that it references: #6178
There was a problem hiding this comment.
I cherrypicked specific PR ed34f00
cartant
approved these changes
Apr 15, 2021
benlesh
approved these changes
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is manual revert to #5874.
Core team have discussed around #5919 for a while, and at this moment pretty much agreed
count#5784) is too much breaking especially we don't have good workaround to suggest.At least, providing as-is experience between v6 to v7 is something we'd like to have instead of making huge breaking changes. This doesn't mean we'll stay with this forever, it's just hard enough find right solution (and doesn't break whole world).
I'm making this PR to v7 not slip this accidentally when we publish official release.
Description:
Related issue (if exists):