Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Observable teardowns now properly called if useDeprecatedSynchronousErrorHandling is true. #6365

Merged
merged 1 commit into from
May 5, 2021
Merged

fix: Observable teardowns now properly called if useDeprecatedSynchronousErrorHandling is true. #6365

merged 1 commit into from
May 5, 2021

Conversation

benlesh
Copy link
Member

@benlesh benlesh commented May 5, 2021

Resolves an issue where teardowns returned by the Observable initializer were not being registered with the subscriber.

Fixes #6364

cc @leggechr

@benlesh
fix: Observable teardowns now properly called if `useDeprecatedSynchr…
9b6050b 
…onousErrorHandling` is `true`.

Resolves an issue where teardowns returned by the Observable initializer were not being registered with the subscriber.

Fixes ReactiveX#6364
@benlesh benlesh requested a review from cartant May 5, 2021 19:17
@benlesh benlesh merged commit e19e104 into ReactiveX:master May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cartant cartant cartant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

useDeprecatedSynchronousErrorHandling not calling teardown if synchronously unsubscribed
2 participants
@benlesh @cartant