Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SwitchOnFirst stress test: investigate flaky test #2789

Closed
simonbasle opened this issue Sep 24, 2021 · 0 comments · Fixed by #2794
Closed

SwitchOnFirst stress test: investigate flaky test #2789

simonbasle opened this issue Sep 24, 2021 · 0 comments · Fixed by #2794
Assignees
@OlegDokuka
Labels
status/need-investigation This needs more in-depth investigation
Milestone
3.4.11

Comments

@simonbasle
Copy link
Member 

   [FAILED] reactor.core.publisher.FluxSwitchOnFirstStressTest.InboundSubscribeAndOutboundCancelAndInboundCompleteStressTest
    (JVM args: [-XX:+UnlockDiagnosticVMOptions, -XX:+WhiteBoxAPI, -XX:-RestrictContended, -Dfile.encoding=UTF-8, -Duser.country, -Duser.language=en, -Duser.variant, -XX:-TieredCompilation, -XX:+StressLCM, -XX:+StressGCM])
             Observed state   Occurrences   Expectation  Interpretation                                              
  0, 0, 1, 1, 1, 1, 0, 0, 1        10,230     FORBIDDEN  No default case provided, assume FORBIDDEN                  
  0, 0, 1, 1, 1, 1, 2, 0, 1       408,131    ACCEPTABLE  Cancellation happened as the earliest event. firstValue i...
  0, 0, 1, 2, 2, 0, 1, 1, 0        60,230    ACCEPTABLE  Inbound got second request, delivered onNext('value') and...
  0, 0, 1, 2, 2, 1, 2, 1, 0        65,350    ACCEPTABLE  Inbound got second request, delivered onNext('value') but...

This is occurring from time to time on main branch, and disappears on subsequent runs.

What's concerning is the number of FORBIDDEN state occurrences (10K), which might indicate an actual bug in the operator 🤔
@simonbasle simonbasle added the status/need-investigation This needs more in-depth investigation label Sep 24, 2021
@simonbasle simonbasle added this to the 3.4.11 milestone Sep 24, 2021
simonbasle added a commit that referenced this issue Sep 24, 2021
@simonbasle
Temporarily mark switchOnFirst result ACCEPTABLE_INTERESTING (see #2789)
23f3a7b
@simonbasle simonbasle linked a pull request Sep 28, 2021 that will close this issue
SwitchOnFirst better tracks in/out premature close #2794
Merged
simonbasle pushed a commit that referenced this issue Sep 28, 2021
@OlegDokuka
SwitchOnFirst better tracks in/out premature close (#2794)
af0b3e8 
This commit adds an extra state to indicate the scenario when the downstream
cancels / receives an error before the inner upstream was terminated.

In that case, we generate inbound prematurely close to propagate extra
cancellation exception

Fixes #2789.

Signed-off-by: Oleh Dokuka odokuka@vmware.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OlegDokuka OlegDokuka

Labels
status/need-investigation This needs more in-depth investigation
Projects
None yet
Milestone
3.4.11
Development

Successfully merging a pull request may close this issue.

SwitchOnFirst better tracks in/out premature close reactor/reactor-core
2 participants
@OlegDokuka @simonbasle