Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #719 Filter the empty buffers emitted by the Publisher #720

Closed
wants to merge 1 commit into from

Conversation

violetagg
Copy link
Member

Mark the promise as successful and do not proceed with writing.

Mark the promise as successful and do not proceed with writing.
@violetagg violetagg added this to the 0.8.7.RELEASE milestone Apr 19, 2019
@violetagg violetagg requested a review from smaldini April 19, 2019 17:07
@codecov-io
Copy link

codecov-io commented Apr 19, 2019

Codecov Report

❗ No coverage uploaded for pull request base (0.8.x@b15da7d). Click here to learn what that means.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff            @@
##             0.8.x     #720   +/-   ##
========================================
  Coverage         ?   65.73%           
  Complexity       ?     1402           
========================================
  Files            ?      130           
  Lines            ?     6628           
  Branches         ?      891           
========================================
  Hits             ?     4357           
  Misses           ?     1776           
  Partials         ?      495
Impacted Files Coverage Δ Complexity Δ
...eactor/netty/channel/ChannelOperationsHandler.java 70.86% <50%> (ø) 66 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b15da7d...2157846. Read the comment docs.

@smaldini
Copy link
Contributor

smaldini commented May 1, 2019

Superseeded by #725

@smaldini smaldini closed this May 1, 2019
Copy link
Contributor

@smaldini smaldini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since channeloperationshandler is rewritten in #725 we have ported the tests and fixes here

@smaldini smaldini deleted the issue-719 branch May 3, 2019 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants