Skip to content

Commit 73bca2b

Browse files
authored
style(Image): match new alignment selectors (#992)
| 🎫 Fix RM-11105, RM-11116 | | :-----------------------------: | ## 🧰 Changes - [x] update our image alignment rulesets to match the new MDX selectors ## 🧬 QA & Testing Checkout the `style/image/match-new-alignment-selectors` branch, run `start`, and open up [this example in the playground][local]. Try switching the `<Image[align]>` prop from "left" to "center" to "right". If it’s reflected correctly in the right-side render, this worked! 🎉 [local]: http://localhost:9966/#/edited?edit=%3CImage+align%3D%22right%22+width%3D%2250%25+%22+src%3D%22https%3A%2F%2Fmedia.istockphoto.com%2Fid%2F589125884%2Fphoto%2Fman-eating-pizza-and-making-an-ok-gesture.jpg%3Fs%3D170667a%26w%3D0%26k%3D20%26c%3DcGTsJbWLAYyOjev9zFhWp6iYX-p39qsrvTEsF699NfI%3D%22+%2F%3E%0A%0ALorem+ipsum+odor+amet%2C+consectetuer+adipiscing+elit.+Blandit+morbi+fames+quisque+mattis+tellus+augue.+Torquent+conubia+enim+malesuada+sagittis+vivamus+penatibus+facilisis+odio.+Non+elementum+phasellus+inceptos+erat+ullamcorper+eros+dictum+ex+condimentum%3F+Nisi+porta+nullam+sodales+diam+risus+donec.+Porttitor+congue+malesuada+cubilia+adipiscing+vehicula.%0A%0ALorem+ipsum+odor+amet%2C+consectetuer+adipiscing+elit.+Blandit+morbi+fames+quisque+mattis+tellus+augue.+Torquent+conubia+enim+malesuada+sagittis+vivamus+penatibus+facilisis+odio.+Non+elementum+phasellus+inceptos+erat+ullamcorper+eros+dictum+ex+condimentum%3F+Nisi+porta+nullam+sodales+diam+risus+donec.+Porttitor+congue+malesuada+cubilia+adipiscing+vehicula.%0A%0ALorem+ipsum+odor+amet%2C+consectetuer+adipiscing+elit.+Blandit+morbi+fames+quisque+mattis+tellus+augue.+Torquent+conubia+enim+malesuada+sagittis+vivamus+penatibus+facilisis+odio.+Non+elementum+phasellus+inceptos+erat+ullamcorper+eros+dictum+ex+condimentum%3F+Nisi+porta+nullam+sodales+diam+risus+donec.+Porttitor+congue+malesuada+cubilia+adipiscing+vehicula.
1 parent 1242413 commit 73bca2b

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

components/Image/style.scss

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,15 +28,19 @@
2828
outline: none !important;
2929
vertical-align: middle;
3030

31+
&.img-align-right,
3132
&[align='right'],
3233
&[alt~='align-right'] {
3334
@extend %img-align-right;
3435
}
3536

37+
&.img-align-left,
3638
&[align='left'],
3739
&[alt~='align-left'] {
3840
@extend %img-align-left;
41+
3942
}
43+
&.img-align-center,
4044
&[align='middle'], // hack to fix Firefox; see: https://stackoverflow.com/a/45901819/1341949
4145
&[align='center'],
4246
&[alt~='align-center'] {
@@ -65,8 +69,10 @@
6569
}
6670
}
6771

72+
> .img,
6873
> img,
6974
figure > img {
75+
display: block;
7076
@extend %img-align-center;
7177
}
7278

0 commit comments

Comments
 (0)