From f08945990bdb86cd942bd97df2ae68b3f017ff52 Mon Sep 17 00:00:00 2001 From: David Fischer Date: Mon, 30 Sep 2019 23:48:50 -0700 Subject: [PATCH 1/2] Improve the version listview - No more than 100 inactive versions - Filter inactive versions by name --- readthedocs/projects/views/public.py | 7 +++++++ .../projects/project_version_list.html | 19 +++++++++++++++++-- 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/readthedocs/projects/views/public.py b/readthedocs/projects/views/public.py index 0b61a0ec5db..a9f005516d6 100644 --- a/readthedocs/projects/views/public.py +++ b/readthedocs/projects/views/public.py @@ -287,7 +287,14 @@ def project_versions(request, project_slug): only_active=False, ) active_versions = versions.filter(active=True) + + # Limit inactive versions in case a project has a large number of branches or tags + # Filter inactive versions based on the query string inactive_versions = versions.filter(active=False) + version_filter = request.GET.get('version_filter', '') + if version_filter: + inactive_versions = inactive_versions.filter(verbose_name__icontains=version_filter) + inactive_versions = inactive_versions[:100] # If there's a wiped query string, check the string against the versions # list and display a success message. Deleting directories doesn't know how diff --git a/readthedocs/templates/projects/project_version_list.html b/readthedocs/templates/projects/project_version_list.html index 695770b196e..4e49745d390 100644 --- a/readthedocs/templates/projects/project_version_list.html +++ b/readthedocs/templates/projects/project_version_list.html @@ -78,7 +78,22 @@

{% trans "Active Versions" %}

{% if inactive_versions %}
-

{% trans "Inactive Versions" %}

+

{% trans "Activate a version" %}

+

{% trans "Active versions are built whenever new code is pushed to that branch or tag." %}

+
+ + {# Version search #} +
@@ -104,7 +119,7 @@

{% trans "Inactive Versions" %}

{% if request.user|is_admin:project %} {% endif %} From 50afb5742b564c7b91b3bca60c01afe2ff51a7d5 Mon Sep 17 00:00:00 2001 From: David Fischer Date: Fri, 4 Oct 2019 09:23:10 -0700 Subject: [PATCH 2/2] Edit & Activate -> Activate --- readthedocs/templates/projects/project_version_list.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/readthedocs/templates/projects/project_version_list.html b/readthedocs/templates/projects/project_version_list.html index 4e49745d390..30be91e3398 100644 --- a/readthedocs/templates/projects/project_version_list.html +++ b/readthedocs/templates/projects/project_version_list.html @@ -119,7 +119,7 @@

{% trans "Activate a version" %}

{% if request.user|is_admin:project %} {% endif %}