Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Dynamic PDF Rendering #1046

Closed
Mentors4EDU opened this issue Feb 8, 2021 · 6 comments
Closed

Feature: Dynamic PDF Rendering #1046

Mentors4EDU opened this issue Feb 8, 2021 · 6 comments

Comments

@Mentors4EDU
Copy link

Mentors4EDU commented Feb 8, 2021

Problem

Some images that are too big aren't resized or too many whitespaces are added in the PDF between subheadings or figures. Also HTML and buttons don't render well in PDFs.

Reproducible Project

Whitespaces
Images
Error

Expected Results

I would like the PDF generation feature to be a bit more responsive. Again, this is just a feature request. rtd is really well developed, but this is just one of my biggest pet peeves. It would help many developers who want to publish their documentation PDFs from their rtd theme. Just a personal suggestion, but if this is a feature request you are willing to look into, I would love to subscribe to it.

@stsewd
Copy link
Member

stsewd commented Feb 8, 2021

@Mentors4EDU do you know how other themes handle this? or some examples with other themes where this looks better?

@Mentors4EDU
Copy link
Author

I am actually not quite sure of how other themes handle the PDF generation

@stsewd
Copy link
Member

stsewd commented Feb 9, 2021

Also, just for clarification, you mean pdf generation from the live site? You can also build a pdf directly from sphinx https://docs.readthedocs.io/_/downloads/en/stable/pdf/

@Mentors4EDU
Copy link
Author

Mentors4EDU commented Feb 10, 2021

PDF generation for docs sites using this theme has these sort of problems. It does seem buggy. An example is, https://lonero.readthedocs.io/_/downloads/en/latest/pdf/ and I know other developers also likely have similar problems.

@stsewd
Copy link
Member

stsewd commented Feb 10, 2021

Ok, thanks for the link, now I see what you mean

@Blendify
Copy link
Member

The styling for pdfs is handled by sphinx, not the theme so file a bug with sphinx directly.
I reported this a while ago sphinx-doc/sphinx#8253 and it should be fixed in sphinx version 4.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants