Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require sphinxcontrib-jquery >=4.0 #1481

Closed
wants to merge 1 commit into from

Conversation

chris48s
Copy link

4d6de11 adds an import to a function which only exists in sphinxcontrib-jquery>=4.0

Upgrading from sphinx-rtd-theme==1.2.0 to sphinx-rtd-theme==1.2.1 with sphinxcontrib-jquery==2.0.0 already in your lockfile or virtualenv causes ImportError: cannot import name 'add_js_files' from 'sphinxcontrib.jquery' to be thrown.

This PR pins sphinxcontrib-jquery to a compatible range.

@chris48s chris48s requested a review from a team as a code owner May 23, 2023 19:03
@benjaoming
Copy link
Contributor

benjaoming commented May 23, 2023

Thanks @chris48s

This was also in #1446

I agree that it should be merged 👍

@chris48s
Copy link
Author

Apologies for the duplicate. Feel free to just close this if you prefer to merge the other one.

@benjaoming
Copy link
Contributor

Oh it's me who's thankful 🙏 It's very nice that you've illustrated the issue about lock files and motivated to get this change in 👍

@benjaoming benjaoming closed this May 23, 2023
@benjaoming
Copy link
Contributor

@chris48s implementing this change in #1446 - it might not get out until 1.3.0, it implies to drop Sphinx 1.7 support, so just need to make that noted somewhere (there's this unknown pile of very old documentation projects that are still being built)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants