Don't revert ownership of offline sessions to the Engine in Sole Library mode

[RichardWarburton]

No description provided.

[guoguanglei]

One issue with this is we can not try to re-connect the session with that FixLibrary when Artio work as initiator.

If try to re-connect, we will receive "Duplicate Session..." because isOwnedSession in below code return true.

artio/artio-core/src/main/java/uk/co/real_logic/artio/engine/framer/Framer.java

Line 854 in d940787

if (sessionContext == SessionContexts.DUPLICATE_SESSION || isOwnedSession(sessionContext.sessionId()))

Can we make the retain owner ship configurable and default to false?

Current work around is set sessionExistsHandler to AcquiringSessionExistsHandler directly instead of set InitialAcceptedSessionOwner to SOLE_LIBRARY.

[RichardWarburton]

Hi Gary,

Adding more and more configuration options for different behaviors is a bit of a whack-a-mole situation. I think setting InitialAcceptedSessionOwner to SOLE_LIBRARY affecting initiating sessions is a bug. That shouldn't be the case. If a library reconnects the session and owns it then Artio should just make that work without further configuration. Happy to fix that.

Am I right in thinking that this can just be replicated by having an initiator Session connect and then disconnect and then attempt to reconnect?

[guoguanglei]

Am I right in thinking that this can just be replicated by having an initiator Session connect and then disconnect and then attempt to reconnect?

Correct

[RichardWarburton]

@guoguanglei I've pushed a fix for this. It will be in the next Artio release - hopefully today.