Remove @IBOutlet and @IBInspectable from UnusedDeclarationRule (#3432)

The original implementation wasn't tested so it regressed. #3184
realm · Dec 3, 2020 · 03f13e5 · 03f13e5
1 parent 0c5136d
commit 03f13e5
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -86,7 +86,9 @@
 
 #### Bug Fixes
 
-* None.
+* Remove `@IBOutlet` and `@IBInspectable` from UnusedDeclarationRule.  
+  [Keith Smiley](https://github.com/keith)
+  [#3184](https://github.com/realm/SwiftLint/issues/3184)
 
 ## 0.41.0: World’s Cleanest Voting Booth
 

diff --git a/Source/SwiftLintFramework/Rules/Lint/UnusedDeclarationRule.swift b/Source/SwiftLintFramework/Rules/Lint/UnusedDeclarationRule.swift
@@ -268,8 +268,6 @@ private let declarationKindsToSkip: Set<SwiftDeclarationKind> = [
 
 private let declarationAttributesToSkip: Set<SwiftDeclarationAttributeKind> = [
     .ibaction,
-    .ibinspectable,
-    .iboutlet,
     .main,
     .nsApplicationMain,
     .override,

diff --git a/Source/SwiftLintFramework/Rules/Lint/UnusedDeclarationRuleExamples.swift b/Source/SwiftLintFramework/Rules/Lint/UnusedDeclarationRuleExamples.swift
@@ -126,6 +126,20 @@ struct UnusedDeclarationRuleExamples {
             func applicationWillFinishLaunching(_ notification: Notification) {}
             func applicationWillBecomeActive(_ notification: Notification) {}
         }
+        """),
+        Example("""
+        import Foundation
+
+        public final class Foo: NSObject {
+            @IBAction private func foo() {}
+        }
+        """),
+        Example("""
+        import Foundation
+
+        public final class Foo: NSObject {
+            @objc func foo() {}
+        }
         """)
     ]
 
@@ -146,6 +160,20 @@ struct UnusedDeclarationRuleExamples {
             func applicationWillFinishLaunching(_ notification: Notification) {}
             func applicationWillBecomeActive(_ notification: Notification) {}
         }
+        """),
+        Example("""
+        import Foundation
+
+        public final class Foo: NSObject {
+            @IBOutlet var ↓bar: NSObject!
+        }
+        """),
+        Example("""
+        import Foundation
+
+        public final class Foo: NSObject {
+            @IBInspectable var ↓bar: String!
+        }
         """)
     ]
 #else