Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update file_name rule to match fully-qualified names of nested types #5841

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Commits on Oct 29, 2024

  1. Update file_name rule to match fully-qualified names of nested types

    This PR is aimed to address Issue realm#5840. It does the following:
    
    1. Allows the `file_name` rule to match nested types when using fully-qualified names, meaning naming the following file `Nested.MyType.swift` is no longer a violation:
    
    ```
    // Nested.MyType.swift
    
    enum Nested {
        struct MyType {
        }
    }
    ```
    
    2. Introduces a new option `fully_qualified` to have the `file_name` rule enforce using fully-qualified names, meaning naming the above file `MyType.swift` instead of `Nested.MyType.swift` would become a violation where it wasn't before (naming the file `Nested.swift` would still not be a violation).
    Nick Fraioli committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    904bad2 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. Address review comments

    Nick Fraioli committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    8e375e7 View commit details
    Browse the repository at this point in the history