From 390e6d7e20aecf45e2562a3d69ee4682efcda091 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B8rgen=20Edelbo?= Date: Tue, 25 May 2021 13:55:20 +0200 Subject: [PATCH] Update after review #1 --- test/object-store/results.cpp | 10 ---------- test/test_global_key.cpp | 21 --------------------- 2 files changed, 31 deletions(-) diff --git a/test/object-store/results.cpp b/test/object-store/results.cpp index 476cb8f879a..66a35df0694 100644 --- a/test/object-store/results.cpp +++ b/test/object-store/results.cpp @@ -3248,16 +3248,6 @@ TEMPLATE_TEST_CASE("results: get() intermixed with writes", "", ResultsFrom r->begin_transaction(); - /* - * We no longer insert based on pk. Objects will always be inserted at the end. - SECTION("front insertion") { - for (int i = 0; i < 1000; ++i) { - table->create_object_with_primary_key(1000 - i); - REQUIRE(results.get(0).get(col_value) == 1000 - i); - } - } - */ - SECTION("append at end") { for (int i = 0; i < 1000; ++i) { table->create_object_with_primary_key(i); diff --git a/test/test_global_key.cpp b/test/test_global_key.cpp index 53226def85c..fa9454bf581 100644 --- a/test/test_global_key.cpp +++ b/test/test_global_key.cpp @@ -75,24 +75,3 @@ TEST(GlobalKey_Compare) CHECK_LESS(GlobalKey(0, 0), GlobalKey(0, 1)); CHECK_LESS(GlobalKey(0, 0), GlobalKey(1, 0)); } - -/* -TEST(GlobalKey_PrimaryKey) -{ - { - GlobalKey object_id(Mixed{}); - auto oid = object_id.to_string(); - CHECK_EQUAL(oid, "{0001-0000}"); - } - { - GlobalKey object_id{123}; - auto oid = object_id.to_string(); - CHECK_EQUAL(oid, "{0000-007b}"); - } - { - GlobalKey object_id{"Exactly!"}; - auto oid = object_id.to_string(); - CHECK_EQUAL(oid, "{495f44d153789d90-d2f64663ba17c5bc}"); - } -} -*/