Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't report non ssl related errors as fatal in default socket provider #6434

Closed
sync-by-unito bot opened this issue Mar 23, 2023 · 0 comments · Fixed by #6539
Closed

Don't report non ssl related errors as fatal in default socket provider #6434

sync-by-unito bot opened this issue Mar 23, 2023 · 0 comments · Fixed by #6539
Assignees

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Mar 23, 2023

The default socket provider is returning a tls handshake failed error for any failures that occur during the TLS handshake, including connections that are lost during the handshake. This error translates to a fatal error that is reported to the user and the client app will use the max wait time (~1 hour) before attempting to reconnect to the server.

Update the default socket provider to only use the tls handshake failed error when that specific failure occurs and return a different error (e.g. going away) for the other connection/communication related errors.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant