Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace notion of 'validity' with that of 'attachment' #139

Merged
merged 5 commits into from
Aug 30, 2013
Merged

Replace notion of 'validity' with that of 'attachment' #139

merged 5 commits into from
Aug 30, 2013

Conversation

kspangsege
Copy link
Contributor

  1. Rename Table::is_valid() -> Table::is_attached().
  2. Modify Group::is_attached() so that in the case of a group managed by a shared group, it returns true when, and only when a transaction is active. This requires that it is no longer tied to the state of attachment of the slab allocator to an underlying file.

\cc @bmunkholm

@bmunkholm
Copy link
Contributor

Ok to merge into master, since the rename only affects Java, and not customers as of now :-)
Going forward we should onle add the "&g_dyn_tabl_...." anchors to the documentation if it is reusable by he bindings - i.e. genericly described.

… when there is no active transaction. This commit also improves exception safety in a number of ways. It also brings replication into a state where it compiles again.
@kspangsege
Copy link
Contributor Author

Brian, I don't think a flag based alternative would be any easier to read that the 'goto' version.

@kspangsege
Copy link
Contributor Author

Alexander, I'll merge this pull request now, but feel free to review.

kspangsege added a commit that referenced this pull request Aug 30, 2013
Replace notion of 'validity' with that of 'attachment'
@kspangsege kspangsege merged commit d7a8a0a into realm:master Aug 30, 2013
@kspangsege kspangsege deleted the ks-is-attached branch August 30, 2013 17:55
tgoyne pushed a commit that referenced this pull request Jul 11, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants