Add an explicit instantiation of Table::find_first for BinaryData #2823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other explicit instantiations were added in #2624, but `BinaryData` was overlooked.
|
Please check your coverage here: https://ci.realm.io/job/realm/job/realm-core/job/PR-2823/1/Diff_Coverage |
|
Check the performance result here: https://ci.realm.io/job/realm/job/realm-core/job/PR-2823/1/Performance_Report |
|
Please check your coverage here: https://ci.realm.io/job/realm/job/realm-core/job/PR-2823/2/Diff_Coverage |
|
Check the performance result here: https://ci.realm.io/job/realm/job/realm-core/job/PR-2823/2/Performance_Report |
finnschiermer
approved these changes
Aug 29, 2017
bdash
added a commit
that referenced
this pull request
Sep 1, 2017
bdash
added a commit
that referenced
this pull request
Sep 1, 2017
Add a missing changelog entry for #2823
fealebenpae
pushed a commit
that referenced
this pull request
Sep 6, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other explicit instantiations were added in #2624, but
BinaryDatawas overlooked.Needed to address realm/realm-object-store#526.