Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use of wrong allocator when running query over links #3935

Merged
merged 1 commit into from
Sep 23, 2020

Conversation

jedelbo
Copy link
Contributor

@jedelbo jedelbo commented Sep 23, 2020

If we use the wrong allocator to translate refs belonging to a table
m_ref_translation_ptr may not point to the most recent mapping.

Fixes realm/realm-java#7118

@cmelchior
Copy link
Contributor

Could this result in NoSuchTable errors? Like realm/realm-java#7100

@finnschiermer finnschiermer changed the title Fix allocator bug when running query over links Fix use of wrong allocator when running query over links Sep 23, 2020
@jedelbo jedelbo force-pushed the je/fix-allocator-bug branch from f5fd07b to 45c1279 Compare September 23, 2020 12:56
Copy link
Contributor

@finnschiermer finnschiermer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AWESOME .... And.....changelog update.

@jedelbo
Copy link
Contributor Author

jedelbo commented Sep 23, 2020

Could this result in NoSuchTable errors? Like realm/realm-java#7100

Unfortunately not.

If we use the wrong allocator to translate refs belonging to a table
m_ref_translation_ptr may not point to the most recent mapping.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash caused by JNI
3 participants