Ensure column keys in virgin tables are unique on 32bit devices #4051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedelbo
changed the title
finnschiermer
approved these changes
Nov 9, 2020
|
Does this fix already upgraded files? |
No :-(. The files that has been upgraded and end up being inconsistent cannot be rescued. |
|
Or probably more correct: The files can be fixed - but not automatically. It would impose a very big runtime overhead to run a complete consistency check on every realm open. |
|
Could we make an option to run a consistency check? Would that be a bad idea? I'm not too fond of bloating the API with those "debugging" features... How many have experienced this though? |
bmunkholm
reviewed
Nov 9, 2020
| @@ -5,7 +5,7 @@ | |||
|
|
|||
| ### Fixed | |||
| * <How to hit and notice issue? what was the impact?> ([#????](https://github.com/realm/realm-core/issues/????), since v?.?.?) | |||
| * None. | |||
| * Files upgraded on 32-bit devices could end up being inconsistent resulting in "Key not found" exception to be thown. ([#6992](https://github.com/realm/realm-java/issues/6992), since v6.0.16) | |||
There was a problem hiding this comment.
@jedelbo Can you add when that could happen?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If column keys are not unique we end up finding the wrong backlink column during upgrade.
Fixes realm/realm-java#6992