Do not lock destroyed mutex after wait_for_upload timeout #5944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
Changes in #5897 made it so we throw an exception and continue running tests after a call to wait_for_session times out instead of immediately calling std::abort. However, when the sync session becomes inactive and all registered notification callbacks get called with an operation_aborted error code, the callback in wait_for_session attempts to acquire a lock on a mutex that was destroyed when wait_for_session threw and the test suite fails with an uncaught std::system_error.
This change makes it so that the callback is operating on state in a weak_ptr so that if the call to wait_for_session times out and we don't care about getting the callback result anymore, we can just ignore it.
☑️ ToDos