Restore barrier on exfat #6033
Merged
Restore barrier on exfat #6033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicola-cab
commented
Nov 15, 2022
evergreen/config.yml
Outdated
| @@ -933,6 +933,7 @@ buildvariants: | |||
| tasks: | |||
| - name: compile_test | |||
| - name: swift-build-and-test | |||
| - name: test-on-exfat | |||
There was a problem hiding this comment.
Temporary, in order to see if 45min are enough
ironage
reviewed
Nov 15, 2022
src/realm/util/file.cpp
Outdated
| @@ -1045,10 +1045,10 @@ void File::barrier() | |||
| // If F_BARRIERSYNC is not suppported (this is known on exFAT) we don't fallback to sync(). | |||
There was a problem hiding this comment.
can you change this comment back as well?
There was a problem hiding this comment.
ah, sorry.. yes, you are right.
ironage
approved these changes
Nov 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
Restore barrier on exfat.
☑️ ToDos