-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Update to latest BAAS test server. #7601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Ready for review |
rorbech
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a bit unclear whether the workaround for the race is working or just trying to reduce it. I guess it works for me, if it succeeds to a reasonably level. But given previous flaky scenarios we should maybe hesitate to merge. Is it on our side, have somebody looked into the server log and/or is there an issue to track this.
realm/realm-library/src/androidTestObjectServer/kotlin/io/realm/admin/ServerAdmin.kt
Outdated
Show resolved
Hide resolved
clementetb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| } | ||
|
|
||
| // Work-around for /deployments reporting success, but /register still failing. | ||
| SystemClock.sleep(5000) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙈
|
I'm still debugging this with the Server team, I have a reproduction case, and it very clearly points to a race condition. 5 seconds was bit arbitrary, but I have not seen any errors after adding it. It adds about 30-45 seconds to the total test time. So seems an acceptable work-around until we can get to the bottom of it. (We need the latest server in order to work on Flexible Sync) |
No description provided.