Skip to content

Conversation

@cmelchior
Copy link
Contributor

No description provided.

@cla-bot cla-bot bot added the cla: yes label Nov 28, 2021
@cmelchior
Copy link
Contributor Author

Ready for review

Copy link
Contributor

@rorbech rorbech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a bit unclear whether the workaround for the race is working or just trying to reduce it. I guess it works for me, if it succeeds to a reasonably level. But given previous flaky scenarios we should maybe hesitate to merge. Is it on our side, have somebody looked into the server log and/or is there an issue to track this.

Copy link
Collaborator

@clementetb clementetb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

}

// Work-around for /deployments reporting success, but /register still failing.
SystemClock.sleep(5000)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@cmelchior
Copy link
Contributor Author

I'm still debugging this with the Server team, I have a reproduction case, and it very clearly points to a race condition. 5 seconds was bit arbitrary, but I have not seen any errors after adding it. It adds about 30-45 seconds to the total test time. So seems an acceptable work-around until we can get to the bottom of it.

(We need the latest server in order to work on Flexible Sync)

@cmelchior cmelchior merged commit c359e60 into master Dec 2, 2021
@cmelchior cmelchior deleted the cm/update-test-server branch December 2, 2021 09:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants