Made Realm.compactRealmFile() more failure resilient. #955

cmelchior · 2015-03-12T07:33:48Z

Awaits a new core release with fix for compact() on empty Realms.
Fixes compactRealmFile() doesn't cleanup properly #953

Realm.compactRealmFile() now uses the methods provided by core which are more failure resilient.

@emanuelez @kneth @bmunkholm

kneth · 2015-03-12T13:43:59Z

We should definitely start using core's compact() method.

cmelchior · 2015-03-12T19:00:46Z

I have added cores compact method and we now use that instead
@emanuelez @kneth

emanuelez · 2015-03-12T19:13:10Z

realm/src/main/java/io/realm/Realm.java

-        Realm realm = null;
+        String path = realmFile.getAbsolutePath();
+        if (openRealms.get(path.hashCode()).get() > 0) {
+            throw new IllegalStateException("Cannot compact a open Realm");


kneth · 2015-03-13T07:51:51Z

Besides my comments: 👍

bmunkholm · 2015-03-13T08:11:26Z

realm/src/main/java/io/realm/Realm.java

@@ -1717,32 +1716,28 @@ public static synchronized boolean deleteRealmFile(Context context, String fileN
     *
     * @param context an Android {@link android.content.Context}
     * @param fileName the name of the file to compact
+     * @param key Key for opening a encrypted Realm.


kneth · 2015-03-20T00:30:16Z

realm/src/androidTest/java/io/realm/RealmTest.java

+        } catch (IllegalStateException expected) {
+            return;
+        }
+        fail();


If you move fail() inside the try block, the return isn't needed.

timanglade · 2015-03-20T13:54:08Z

Will repeat this during the “how to talk about Realm” presentation.

“Realm” is always capitalized i.e. “a Realm file” but in some context it’s easier to refer to the file extension, which is lowercase. For example:

“You can compact a Realm file”
“look for the .realm file in your Documents folder“

Conflicts: changelog.txt

…temporarily.

kneth · 2015-04-15T13:57:48Z

I have disabled compacting encrypted Realms as it fails on some devices.

@cmelchior @emanuelez @tgoyne @finnschiermer

cmelchior · 2015-04-15T17:32:10Z

changelog.txt

@@ -1,4 +1,5 @@
 0.81
+ * Realm.compactRealmFile() now also works for encrypted Realms.


Well, no :)

…actfile

Made Realm.compactRealmFile() more failure resilient.

finnschiermer · 2015-05-18T09:26:29Z

This look like a testcase error: when calling compact on the SharedGroup, it must be in the attached state (file must have been opened). In the testcases you close SharedGroup right before calling compact. I guess compact() should detect and assert.

kneth · 2015-05-18T11:33:31Z

@finnschiermer The Realm.compactRealmFile() creates a SharedGroup object (without implicit transactions), compacts the file, and closes the SharedGroup.

finnschiermer · 2015-05-18T11:57:42Z

okidoki

Made compact file more failure resilient.

703512b

cmelchior added 2 commits March 12, 2015 19:58

Added compact() method from core also for encrypted Realms.

7af8aa7

Updated changelog

a403a0a

Fixed unit test.

22c6f26

emanuelez reviewed Mar 12, 2015
View reviewed changes

bmunkholm reviewed Mar 13, 2015
View reviewed changes

cmelchior and others added 4 commits March 13, 2015 11:21

Spelling

6216a8a

Improved error checking and unit test.

dabadec

Merge branch 'master' into cm-bug-compactfile

ee0ff69

Add a couple of unit tests

d29179c

kneth reviewed Mar 20, 2015
View reviewed changes

kneth mentioned this pull request Apr 15, 2015

Updating to Realm Core 0.89.0 #1030

Merged

cmelchior and others added 3 commits April 15, 2015 10:31

Merge branch 'master' into cm-bug-compactfile

458dcba

Conflicts: changelog.txt

Cleanup

b69d6ca

Compacting encrypted Realms fail on some devices, and it is disabled …

880ed79

…temporarily.

kneth mentioned this pull request Apr 15, 2015

Compacting encrypted Realms fail on some devices realm/realm-core#763

Closed

cmelchior reviewed Apr 15, 2015
View reviewed changes

changelog.txt

@@ -1,4 +1,5 @@

0.81

* Realm.compactRealmFile() now also works for encrypted Realms.

Copy link

Contributor Author

cmelchior Apr 15, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, no :)

kneth added 2 commits April 16, 2015 08:59

Merge branch 'master' of github.com:realm/realm-java into cm-bug-comp…

9ba0f1e

…actfile

Updating change log and unit tests

b4dfc2f

kneth pushed a commit that referenced this pull request Apr 16, 2015

Merge pull request #955 from realm/cm-bug-compactfile

da535c6

Made Realm.compactRealmFile() more failure resilient.

kneth merged commit da535c6 into master Apr 16, 2015

emanuelez deleted the cm-bug-compactfile branch October 16, 2015 09:26

github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Made Realm.compactRealmFile() more failure resilient. #955

Made Realm.compactRealmFile() more failure resilient. #955

cmelchior commented Mar 12, 2015

kneth commented Mar 12, 2015

cmelchior commented Mar 12, 2015

emanuelez Mar 12, 2015

kneth commented Mar 13, 2015

bmunkholm Mar 13, 2015

kneth Mar 20, 2015

timanglade commented Mar 20, 2015

kneth commented Apr 15, 2015

cmelchior Apr 15, 2015

finnschiermer commented May 18, 2015

kneth commented May 18, 2015

finnschiermer commented May 18, 2015

		@@ -1,4 +1,5 @@
		0.81
		* Realm.compactRealmFile() now also works for encrypted Realms.

Made Realm.compactRealmFile() more failure resilient. #955

Made Realm.compactRealmFile() more failure resilient. #955

Conversation

cmelchior commented Mar 12, 2015

kneth commented Mar 12, 2015

cmelchior commented Mar 12, 2015

emanuelez Mar 12, 2015

Choose a reason for hiding this comment

kneth commented Mar 13, 2015

bmunkholm Mar 13, 2015

Choose a reason for hiding this comment

kneth Mar 20, 2015

Choose a reason for hiding this comment

timanglade commented Mar 20, 2015

kneth commented Apr 15, 2015

cmelchior Apr 15, 2015

Choose a reason for hiding this comment

finnschiermer commented May 18, 2015

kneth commented May 18, 2015

finnschiermer commented May 18, 2015