Statically cache the String value of g_internal_field for a small performance gain #4863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomduncalf
force-pushed
the
td/v11-optimize-internal-field
branch
from
a73ce43 to
5d3e50a
Compare
RedBeard0531
reviewed
Sep 5, 2022
src/jsi/jsi_class.hpp
Outdated
| @@ -490,7 +490,9 @@ class ObjectWrap { | |||
|
|
|||
| static Internal* get_internal(JsiEnv env, const JsiObj& object) | |||
| { | |||
| auto internal = object->getProperty(env, g_internal_field); | |||
| static const auto js_internal_field = fbjsi::String::createFromAscii(env, g_internal_field); | |||
There was a problem hiding this comment.
This will break on reload since it will continue to use the string from the old env.
There was a problem hiding this comment.
Ah right yeah, good point. I guess there's no way round that? It's not a huge gain anyway so I'm happy to close this if that's best
There was a problem hiding this comment.
Make it a class-static like s_ctor with the same logic to set it on module load and reset on em teardown. This isnt a perfect solution because it assumes at most one env at a time, but it will at least work as well as the rest of the codebase.
There was a problem hiding this comment.
Updated in e32fc5b
|
Waiting on #4869 for lint to pass |
kraenhansen
force-pushed
the
v11
branch
2 times, most recently
from
bf94457 to
a388208
Compare
tomduncalf
force-pushed
the
td/v11-optimize-internal-field
branch
from
e32fc5b to
0b6099f
Compare
kraenhansen
approved these changes
Sep 9, 2022
RedBeard0531
approved these changes
Sep 9, 2022
Co-authored-by: Mathias Stearn <redbeard0531@gmail.com>
Co-authored-by: Mathias Stearn <redbeard0531@gmail.com>
tomduncalf
force-pushed
the
td/v11-optimize-internal-field
branch
from
1e159f6 to
1ed1d1e
Compare
|
Ignoring known failure on Android |
kraenhansen
pushed a commit
that referenced
this pull request
Sep 9, 2022
…formance gain (#4863) * Statically cache the String value of g_internal_field for a small performance gain * Fix lint * Update src/jsi/jsi_class.hpp Co-authored-by: Mathias Stearn <redbeard0531@gmail.com> * Update src/jsi/jsi_class.hpp Co-authored-by: Mathias Stearn <redbeard0531@gmail.com> * Change to empty string for internal field name Co-authored-by: Mathias Stearn <redbeard0531@gmail.com>
kraenhansen
pushed a commit
that referenced
this pull request
Sep 9, 2022
…formance gain (#4863) * Statically cache the String value of g_internal_field for a small performance gain * Fix lint * Update src/jsi/jsi_class.hpp Co-authored-by: Mathias Stearn <redbeard0531@gmail.com> * Update src/jsi/jsi_class.hpp Co-authored-by: Mathias Stearn <redbeard0531@gmail.com> * Change to empty string for internal field name Co-authored-by: Mathias Stearn <redbeard0531@gmail.com>
kraenhansen
pushed a commit
that referenced
this pull request
Sep 9, 2022
…formance gain (#4863) * Statically cache the String value of g_internal_field for a small performance gain * Fix lint * Update src/jsi/jsi_class.hpp Co-authored-by: Mathias Stearn <redbeard0531@gmail.com> * Update src/jsi/jsi_class.hpp Co-authored-by: Mathias Stearn <redbeard0531@gmail.com> * Change to empty string for internal field name Co-authored-by: Mathias Stearn <redbeard0531@gmail.com>
kraenhansen
pushed a commit
that referenced
this pull request
Sep 13, 2022
…formance gain (#4863) * Statically cache the String value of g_internal_field for a small performance gain * Fix lint * Update src/jsi/jsi_class.hpp Co-authored-by: Mathias Stearn <redbeard0531@gmail.com> * Update src/jsi/jsi_class.hpp Co-authored-by: Mathias Stearn <redbeard0531@gmail.com> * Change to empty string for internal field name Co-authored-by: Mathias Stearn <redbeard0531@gmail.com>
kraenhansen
pushed a commit
that referenced
this pull request
Sep 15, 2022
…formance gain (#4863) * Statically cache the String value of g_internal_field for a small performance gain * Fix lint * Update src/jsi/jsi_class.hpp Co-authored-by: Mathias Stearn <redbeard0531@gmail.com> * Update src/jsi/jsi_class.hpp Co-authored-by: Mathias Stearn <redbeard0531@gmail.com> * Change to empty string for internal field name Co-authored-by: Mathias Stearn <redbeard0531@gmail.com>
takameyer
pushed a commit
that referenced
this pull request
Sep 15, 2022
…formance gain (#4863) * Statically cache the String value of g_internal_field for a small performance gain * Fix lint * Update src/jsi/jsi_class.hpp Co-authored-by: Mathias Stearn <redbeard0531@gmail.com> * Update src/jsi/jsi_class.hpp Co-authored-by: Mathias Stearn <redbeard0531@gmail.com> * Change to empty string for internal field name Co-authored-by: Mathias Stearn <redbeard0531@gmail.com>
kraenhansen
pushed a commit
that referenced
this pull request
Oct 18, 2022
…formance gain (#4863) * Statically cache the String value of g_internal_field for a small performance gain * Fix lint * Update src/jsi/jsi_class.hpp Co-authored-by: Mathias Stearn <redbeard0531@gmail.com> * Update src/jsi/jsi_class.hpp Co-authored-by: Mathias Stearn <redbeard0531@gmail.com> * Change to empty string for internal field name Co-authored-by: Mathias Stearn <redbeard0531@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
This optimisation yields a small (~5% with Hermes disabled, ~2% with Hermes enabled) performance improvement with our benchmark suite, as it avoids the overhead of repeatedly creating the JSI String object.
☑️ ToDos
Compatibilitylabel is updated or copied from previous entrypackage.jsons (if updating internal packages)Breakinglabel has been applied or is not necessaryIf this PR adds or changes public API's: