Allow user to use Xcode 13 #5531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fealebenpae
reviewed
Mar 2, 2023
CMakeLists.txt
Outdated
Comment on lines
84
to
90
| if(APPLE) | ||
| if(NOT DEFINED CMAKE_JS_VERSION) | ||
| # https://developer.apple.com/forums/thread/716965 | ||
| add_cxx_flag_if_supported(-fno-objc-msgsend-selector-stubs) | ||
| endif() | ||
| endif() | ||
|
|
There was a problem hiding this comment.
We want/need this on the realm-js-ios target in src/ios/CMakeLists.txt specifically because that's the one that compiled Objective-C code (platform.mm). No need to define it globally.
takameyer
approved these changes
Mar 3, 2023
There was a problem hiding this comment.
So it seems this is a performance/build optimization added in Xcode 14. Wondering if there would be a time we would want to add this back? Perhaps it would be worthwhile to add a comment stating that this flag can be removed when Xcode 15 is released, assuming by then most users are using Xcode 14.
Good point. Once React Native specify Xcode 14 or later we can safely remove it again. I have created #5533 to track it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
Xcode 14 emits stubs for Objective C code which is incompatible with Xcode 13. See https://developer.apple.com/forums/thread/716965 for details.
This closes #5511
☑️ ToDos
[ ] 📝Compatibilitylabel is updated or copied from previous entry[ ] 📝 UpdateCOMPATIBILITY.md[ ] 🔀 Executed flexible sync tests locally if modifying flexible sync[ ] 📦 Updated internal package version in consumingpackage.jsons (if updating internal packages)[ ] 📝 Public documentation PR created or is not necessary[ ] 💥Breakinglabel has been applied or is not necessaryIf this PR adds or changes public API's:
[ ] typescript definitions file is updated[ ] jsdoc files updated