Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for full text search #5797

Merged
merged 28 commits into from
May 25, 2023
Merged

Added support for full text search #5797

merged 28 commits into from
May 25, 2023

Conversation

papafe
Copy link
Contributor

@papafe papafe commented May 8, 2023

This closes #5755

Depends on updating core to the latest release (#5796). The update has already been merged in this branch.

☑️ ToDos

  • 📝 Changelog entry
  • 🚦 Tests

papafe added 9 commits April 25, 2023 16:55
* main: (25 commits)
  Test against a server running via docker exposed via Ngrok (#5783)
  Updated test-server.yml to be less agressive on the GitHub API
  Update test-server.yml to store into a step output
  Updated test-server.yml to silence "gh run watch"
  Updated test-server.yml to take server tag as argument and compute subdomain in step
  Updated test-server.yml to use --detach if a run_id is provided
  Updated test-server.yml to take the run_id as input
  Updated test-server to only trigger on dispatch
  Test coverage (#5775)
  Arming the test-server workflow
  Make realm unit tests --exit
  Fixing @realm/react tests by upgrading @testing-library/react-native
  Removed unused code from RN test app
  Updated docs for mocha remote context vars
  Update test-server.yml
  Enabling test server for test coverage workflow
  Refreshing access token during import
  Using mongodbServiceType in import-app-before-hook
  Fix mongodb client tests to avoid crosstalks (#5770)
  Reuse app on import and use config builder instead of paths (#5744)
  ...
@cla-bot cla-bot bot added the cla: yes label May 8, 2023
Copy link
Contributor

@kneth kneth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create an issue to add support for the new index type in the Babel plugin.

@kraenhansen kraenhansen changed the title Added support for FTS Added support for full text search May 9, 2023
@coveralls
Copy link

coveralls commented May 9, 2023

Coverage Status

Coverage: 85.702% (+0.2%) from 85.488% when pulling d0c1c17 on fp/minimal-fts into 9651ccf on main.

Copy link
Contributor

@elle-j elle-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great new feature support 🙂 Left some comments. There are minor updates to things not included in this PR that I can add in another PR that targets this branch.

Copy link
Contributor

@takameyer takameyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: Nice!

Copy link
Contributor

@elle-j elle-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! The only thing you may want to wait with is the spec changes. You could coordinate with Mathias on that 👍

papafe added 6 commits May 12, 2023 11:34
* main:
  switch to consuming bindgen from realm-core repo (#5769)

# Conflicts:
#	packages/realm/bindgen/vendor/bindgen-lib/spec.yml
* main:
  Pushing update to the package-lock.json
  Binding resolution refactored (#5802)
  Update install-test-react-native.yml (#5808)
  Add more testing of IN operator (#5809)
papafe added 4 commits May 24, 2023 12:40
* main:
  Remove incorrect info and adds to return description for compact() (#5798)
  Use `declare prop` rather than `prop!` with Object.declareProperty()
  Use Object.defineProperty rather than Object.defineProperties because it is faster
  Update importAppBefore to take an AppConfiguration (#5838)
  Adding `next` to install test matrix (#5819)
  Default session multiplexing to being disabled (#5831)
  Adding types for some "environment" options
  Exposing a defaultLogLevel context option
  Update pr-realm-js.yml
  Update PR workflow to pin the server version
  Update baas test server install script
@papafe papafe merged commit e0a4be2 into main May 25, 2023
@papafe papafe deleted the fp/minimal-fts branch May 25, 2023 08:38
papafe added a commit that referenced this pull request May 25, 2023
* main:
  Added support for full text search (#5797)
  Create workflow for building & uploading realm-react docs (#5828)
  Use correct package name for integration-tests/environments/react-native/android/app/src/release/java/com/realmreactnativetests/ReactNativeFlipper.java
  Minor doc updates (#5839)
  Update Realm.ts

# Conflicts:
#	integration-tests/tests/src/tests/queries.ts
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose minimal full text search
6 participants