Implement queries on lists of primitives #7056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgoyne
force-pushed
the
tg/primitive-list-queries
branch
from
1b13246 to
a7931c5
Compare
jsflax
reviewed
Jan 28, 2021
| NSComparisonPredicateOptions predicateOptions, | ||
| ColumnReference const& column, R const& rhs); | ||
| template <typename... T> | ||
| template <template<typename> typename W, typename T> |
There was a problem hiding this comment.
Can we give these template types better names? I can see how W is being used in the method body, but it seems like a fairly arbitrary designation that could use a bit more self documenting.
There was a problem hiding this comment.
W was initially Wrapper but that name wasn't very accurate and I failed to come up with a good name for it.
tgoyne
force-pushed
the
tg/primitive-list-queries
branch
from
a7931c5 to
7c927e3
Compare
|
Depends on realm/realm-core#4417. |
tgoyne
force-pushed
the
tg/primitive-list-queries
branch
from
fef176d to
20fc3f0
Compare
|
This hit a new assertion failure in one of the CI runs which realm/realm-core#4428 fixes. Since it's a core 10.5.0 bug and not something new in 10.5.1 it's not blocking this. The other CI failures are pre-existing issues and network failures. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also incidentally adds support for a few other things along the way. Binary columns used to not support a lot of queries which were supported on everything else, but they now do and removing the special cases made it a lot easier to support
List<Data>.Depends on some unreleased functionality in core master, so can't be merged until a release is made there and all non-spm tests will fail.
Fixes #5334.