Fix using initialSubscriptions with @AsyncOpen and @AutoOpen #8572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving the storage of intialSubscriptions from RealmConfiguration to SyncConfiguration means that AsyncOpen needs to explicitly copy them over to the newly created SyncConfiguration.
tgoyne
force-pushed
the
tg/swiftui-initial-subscriptions
branch
from
d06feef
to
c44fa8a
Compare
nirinchev
approved these changes
May 3, 2024
Comment on lines
+1540
to
+1543
| } else if let initialSubscriptions { | ||
| config = user.flexibleSyncConfiguration(cancelAsyncOpenOnNonFatalErrors: true, | ||
| initialSubscriptions: ObjectiveCSupport.convert(block: initialSubscriptions.callback), | ||
| rerunOnOpen: initialSubscriptions.rerunOnOpen) |
There was a problem hiding this comment.
Do we have to do something similar for clientResetMode and the before/after callbacks? I haven't looked much into the SwiftUI code, but it appears like something that's not obviously handled in this method.
There was a problem hiding this comment.
Yeah, those are probably broken too. Will fix in a subsequent PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the storage of initialSubscriptions from RealmConfiguration to SyncConfiguration means that AsyncOpen needs to explicitly copy them over to the newly created SyncConfiguration.
It turned out we had no tests for swiftui plus flexible sync, so I made the existing test suite run against both pbs and flx apps.