-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support OCaml 5.3 #457
support OCaml 5.3 #457
Conversation
@voodoos is this the right way to fix this? What about using |
c3b0e07
to
dbc30c1
Compare
I've rebased on top of |
lib/top/compat_top.ml
Outdated
#if OCAML_VERSION >= (5, 3, 0) | ||
; ext_uid = Uid.mk | ||
~current_unit: | ||
(Some (Unit_info.make ~source_file:"mdx.ml" Impl "mdx")) | ||
#elif OCAML_VERSION >= (4, 11, 0) | ||
; ext_uid = Uid.mk ~current_unit:"mdx" | ||
#endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To answer @samoht question I would say that this is the closest way to get the same "current_unit" information as before in the uid
since Uid.make
will use the modname
part of the Unit_info
which is "Mdx"
.
As to whether this information is important to have, I guess it's not (and therefore None
would probably work too), unless there is tooling that expect this information to be "correct". (AFAIK it's only important for tooling.)
For reference, (I don't know if it would make sense here), in the compiler this information is retrieved from the environment: Uid.mk ~current_unit:(Env.get_current_unit ())
Thanks! I've simplified the support as I don't think the tooling needs anything complicated here. |
CHANGES: #### Added - Support OCaml 5.3 (realworldocaml/mdx#457, @anmonteiro, @samoht, @voodoos) - Support multiple version labels in block headers. The block is active if all the version formulaes are satisfied (realworldocaml/mdx#458, @samoht) #### Fixed - Avoid infinite loop in lexer on unclosed code block (realworldocaml/mdx#444, @edwintorok) - Fix support for skipped blocks in mli and mld files (realworldocaml/mdx#462, @samoht)
the expect tests still have some failures like this if ran on 5.3. Any advice on how to make them conditional?