Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add 768 alias #310

Merged
merged 6 commits into from
Sep 30, 2023
Merged

feature: add 768 alias #310

merged 6 commits into from
Sep 30, 2023

Conversation

prestwich
Copy link
Collaborator

Successor to #303

Motivation

Add 96-byte alias

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

@prestwich prestwich added the enhancement New feature or request label Sep 11, 2023
@prestwich prestwich self-assigned this Sep 11, 2023
@prestwich prestwich mentioned this pull request Sep 11, 2023
@prestwich
Copy link
Collaborator Author

CI issues are from issues causing #311

Copy link

@Qumeric Qumeric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :D

@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (d705f65) 80.54% compared to head (926effd) 80.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #310      +/-   ##
==========================================
+ Coverage   80.54%   80.61%   +0.06%     
==========================================
  Files          54       54              
  Lines        6035     6036       +1     
==========================================
+ Hits         4861     4866       +5     
+ Misses       1174     1170       -4     
Files Coverage Δ
src/aliases.rs 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prestwich prestwich merged commit 706ffd0 into main Sep 30, 2023
20 checks passed
@prestwich prestwich deleted the prestwich/768-patch branch September 30, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants