Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve formatting implementations #370

Merged
merged 1 commit into from
May 10, 2024

Conversation

DaniPopes
Copy link
Contributor

Improve formatting implementations by first writing to a local buffer, then using fmt::Formatter::pad_integral to apply padding and all the other flags.

This also standardizes the way the numbers are formatted to the same format that the standard library uses.

@DaniPopes DaniPopes requested a review from prestwich as a code owner May 7, 2024 22:29
@DaniPopes DaniPopes force-pushed the better-formatting branch 2 times, most recently from 115075f to c5bc78a Compare May 7, 2024 22:35
@prestwich prestwich merged commit 2271382 into recmo:main May 10, 2024
17 of 18 checks passed
@DaniPopes DaniPopes deleted the better-formatting branch May 10, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants