Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ambiguous behavior (breaking changes) #20

Closed
zkamvar opened this issue May 17, 2019 · 0 comments · Fixed by #21
Closed

Remove ambiguous behavior (breaking changes) #20

zkamvar opened this issue May 17, 2019 · 0 comments · Fixed by #21
Assignees
Labels
enhancement New feature or request

Comments

@zkamvar
Copy link
Member

zkamvar commented May 17, 2019

Things that should be changed:

  1. behavior of factors
  2. combining aweek objects

After thinking about it (with a bit of help from Rich FitzJohn), I think adding the ability to combine aweek objects with different start days was a mistake. The behavior of simply taking the first element and converting it was a mistake because it will not be obvious to the user what is happening. Combining aweek objects should do the following:

  1. only combine aweek objects with the same week_start attribute
    i. if they don't have the same week_start attribute, an error is thrown, advising the use of change_week_start()
  2. if combining a factor, it is converted to a character, no matter what. The user can use factor_aweek() (or something like that) to change it.
  3. truncated aweek objects are no longer truncated.

Other than that, character and date objects are trivial

zkamvar added a commit that referenced this issue May 17, 2019
@zkamvar zkamvar added the enhancement New feature or request label May 20, 2019
@zkamvar zkamvar self-assigned this May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant