Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrating with the tsibble package #34

Closed
aspina7 opened this issue Jul 3, 2020 · 2 comments
Closed

Integrating with the tsibble package #34

aspina7 opened this issue Jul 3, 2020 · 2 comments

Comments

@aspina7
Copy link

aspina7 commented Jul 3, 2020

Hey - know you are swamped, but just thought I would flag this here as an fyi.

Might be worth integrating aweek in to the tsibble package. Have posted an issue on the tsibble page too.

It's a pretty functional package (with a yearweek function) - have been using it for time series analysis.

This would also address @jpolonsky issues (1 and 2) - because with tsibble can do both those in regular dplyr syntax.

Long shot but would also make the incidence package a lot simpler (i think)

Anyway - food for thought nothing actionable!

have a good one

@zkamvar
Copy link
Member

zkamvar commented Jul 13, 2020

Looks like they took care of it using {lubridate}: tidyverts/tsibble@41fdbf7, which makes sense since they already imported it from the get-go. Their criticism that {aweek} doesn't natively support the + operator is fair. Honestly, I didn't even know that {lubridate} had that feature until after I built {aweek}, and now that I know about it, I'm reluctant to build any more functionality into this since It's just reinventing the wheel.

@aspina7
Copy link
Author

aspina7 commented Jul 13, 2020

Agree - guess leave as is considering incidence2 being built of back of aweek

@aspina7 aspina7 closed this as completed Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants