Fix for Newline with EncapsedStringsToSprintfRector #5060
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Failing Test for EncapsedStringsToSprintfRector Based on https://getrector.org/demo/1b647b4f-dde9-4f90-b05e-74744045a3d1
Add failing test fixture for EncapsedStringsToSprintfRector
samsonasik
reviewed
Dec 31, 2020
| count( | ||
| array_filter( | ||
| $argumentVariables, | ||
| fn($argumentVar): bool => $argumentVar instanceof ConstFetch && $argumentVar->name.'' === 'PHP_EOL' |
There was a problem hiding this comment.
argument->name . '' should can be (string) argument->name
There was a problem hiding this comment.
@samsonasik thanks, guessing you're also building against >7.3 as it doesn't like the return type on the closure
samsonasik
added a commit
that referenced
this pull request
Jan 2, 2021
|
@brucealdridge I cherry-picked your commit at #5072 |
samsonasik
added a commit
that referenced
this pull request
Jan 2, 2021
samsonasik
added a commit
that referenced
this pull request
Jan 2, 2021
|
@samsonasik thank you! Haven't yet had the time to rewrite! |
TomasVotruba
pushed a commit
that referenced
this pull request
Jan 2, 2021
…rintfRector (#5072) * Add failing test fixture for EncapsedStringsToSprintfRector # Failing Test for EncapsedStringsToSprintfRector Based on https://getrector.org/demo/1b647b4f-dde9-4f90-b05e-74744045a3d1 * Fix for prefixed_eol.php.inc * Check against PHP_EOL * allowing newline to be prefixed as well * [CodingStyle] Closes #5060 Fixes #5032 Add %s for pass PHP_EOL constant * skip multiple eol * use PHP_EOL const * [ci-review] Rector Rectify Co-authored-by: bruce aldridge <bruce@incode.co.nz> Co-authored-by: rector-bot <tomas@getrector.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #5032