-
-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Newline with EncapsedStringsToSprintfRector #5060
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
c2bbf87
Add failing test fixture for EncapsedStringsToSprintfRector
brucealdridge 0b058b3
Fix for prefixed_eol.php.inc
brucealdridge 886d493
Merge pull request #1 from brucealdridge/patch-1
brucealdridge a6a638b
Check against PHP_EOL
brucealdridge cff6fec
allowing newline to be prefixed as well
brucealdridge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 27 additions & 0 deletions
27
...oding-style/tests/Rector/Encapsed/EncapsedStringsToSprintfRector/Fixture/newline2.php.inc
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
<?php | ||
|
||
namespace Rector\CodingStyle\Tests\Rector\Encapsed\EncapsedStringsToSprintfRector\Fixture; | ||
|
||
final class Newline2 | ||
{ | ||
public function run(string $format) | ||
{ | ||
return "\n${format}"; | ||
} | ||
} | ||
|
||
?> | ||
----- | ||
<?php | ||
|
||
namespace Rector\CodingStyle\Tests\Rector\Encapsed\EncapsedStringsToSprintfRector\Fixture; | ||
|
||
final class Newline2 | ||
{ | ||
public function run(string $format) | ||
{ | ||
return PHP_EOL . $format; | ||
} | ||
} | ||
|
||
?> |
27 changes: 27 additions & 0 deletions
27
...g-style/tests/Rector/Encapsed/EncapsedStringsToSprintfRector/Fixture/prefixed_eol.php.inc
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
<?php | ||
|
||
namespace Rector\CodingStyle\Tests\Rector\Encapsed\EncapsedStringsToSprintfRector\Fixture; | ||
|
||
final class PrefixedEol | ||
{ | ||
public function run(string $format) | ||
{ | ||
return "prefix $format\n"; | ||
} | ||
} | ||
|
||
?> | ||
----- | ||
<?php | ||
|
||
namespace Rector\CodingStyle\Tests\Rector\Encapsed\EncapsedStringsToSprintfRector\Fixture; | ||
|
||
final class PrefixedEol | ||
{ | ||
public function run(string $format) | ||
{ | ||
return sprintf('prefix %s%s', $format, PHP_EOL); | ||
} | ||
} | ||
|
||
?> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
argument->name . '' should can be (string) argument->name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samsonasik thanks, guessing you're also building against >7.3 as it doesn't like the return type on the closure