This repository has been archived by the owner on Feb 21, 2023. It is now read-only.
Swap out travisci for github actions, swap out go-passe for gotestsum #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbvigilante
reviewed
May 5, 2021
.github/workflows/ci.yml
Outdated
| go-version: '^1.16.1' | ||
| - run: make fmt && git diff --exit-code | ||
| - run: GO111MODULE=off go get gotest.tools/gotestsum | ||
| - run: make test |
There was a problem hiding this comment.
To nitpick, I'd rather all our files either had or did not have newlines at the end. Since basically all our other ones do, can this one as well?
mipearson
force-pushed
the
mp-github-actions
branch
from
5e6ec6a
to
c9fe82c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TravisCI have been moving away from free OSS builds for a while, let's use GH actions instead.
Also avoid a problem where go getting gopasse would change go.mod/sum