This repository has been archived by the owner on Feb 21, 2023. It is now read-only.
Allow choosing GUI pinentry as your auth prompt #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default to old password input, except with --pinentry mode. We want to allow this option for when GUI apps call us in the background and we can't prompt for password/TOTP via stdin/stdout as usual. For now we're making it opt-in, so we don't "move too many people's cheese".
toothbrush
force-pushed
the
paul/pinentry
branch
from
3460ee8
to
fecc766
Compare
toothbrush
changed the title
toothbrush
commented
Oct 15, 2021
| @@ -24,3 +25,5 @@ require ( | |||
| golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2 | |||
| golang.org/x/net v0.0.0-20200202094626-16171245cfb2 | |||
| ) | |||
|
|
|||
| replace github.com/gopasspw/pinentry => github.com/redbubble/pinentry v0.0.3-0.20211015012734-36081cf01f93 | |||
There was a problem hiding this comment.
Using a fork of https://github.com/gopasspw/pinentry because of https://github.com/gopasspw/pinentry/issues/1. The only thing it does is hardcode pinentry-mac instead of (broken) auto lookup the library does. Note that in the Brew package i've added pinentry-mac as a dependency, so i expect this to go fine. It works for me.
mipearson
approved these changes
Oct 15, 2021
Ah, no, not as such – the modification is really very simple. It's just hardcoding the Darwin-case: gopasspw/pinentry@main...redbubble:main I can modify the README if you prefer? |
lokulin
pushed a commit
that referenced
this pull request
Aug 18, 2022
* Depend on pinentry-mac Homebrew formula * Correct my preferred capitalisation if i'm here anyway. * cmd/root.go: Add pinentry option. * cli/login.go: Use pinentry, optionally. Default to old password input, except with --pinentry mode. We want to allow this option for when GUI apps call us in the background and we can't prompt for password/TOTP via stdin/stdout as usual. For now we're making it opt-in, so we don't "move too many people's cheese".
lokulin
pushed a commit
that referenced
this pull request
Aug 18, 2022
* Depend on pinentry-mac Homebrew formula * Correct my preferred capitalisation if i'm here anyway. * cmd/root.go: Add pinentry option. * cli/login.go: Use pinentry, optionally. Default to old password input, except with --pinentry mode. We want to allow this option for when GUI apps call us in the background and we can't prompt for password/TOTP via stdin/stdout as usual. For now we're making it opt-in, so we don't "move too many people's cheese".
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the possibility to use
pinentryto prompt the user for their credentials. We want that in the situation where (e.g.) MySQL Workbench calls ssh which calls yak, and we can't directly prompt the user for their credentials. For now we're making it opt-in, so we don't "move too many people's cheese".