Skip to content
This repository has been archived by the owner on Feb 21, 2023. It is now read-only.

Update pinentry dependency and add Windows support #113

Merged
merged 10 commits into from
Aug 18, 2022
Merged

Update pinentry dependency and add Windows support #113

merged 10 commits into from
Aug 18, 2022

Conversation

lokulin
Copy link
Contributor

@lokulin lokulin commented Aug 17, 2022

Why not?

  • goreleaser supports Windows.
  • Tested on Windows 10 (10.0.19044), including pinentry.

Changes:

  • Now builds for windows.
  • Swapped pinentry library to twpayne/go-pinentry as gopasspw/pinentry is deprecated.

Depends on PR #112

@lokulin lokulin requested a review from a team as a code owner August 17, 2022 11:23
@lokulin lokulin force-pushed the lw-win branch 4 times, most recently from 981ff3a to 6850b4a Compare August 18, 2022 01:53
@lokulin lokulin changed the title Add Windows Support Update pinentry dependency and add Windows support Aug 18, 2022
Copy link
Member

@toothbrush toothbrush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, i think this looks decent now. Thanks for indulging all my nitpicking! 🙏

Let's not forget to delete https://github.com/redbubble/pinentry once we're done here, too.

Co-authored-by: paul david <423357+toothbrush@users.noreply.github.com>
@lokulin lokulin merged commit e2a87f5 into master Aug 18, 2022
@lokulin lokulin deleted the lw-win branch August 18, 2022 05:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants