This repository has been archived by the owner on Feb 21, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
Update pinentry dependency and add Windows support #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lokulin
force-pushed
the
lw-win
branch
4 times, most recently
from
August 18, 2022 01:53
981ff3a
to
6850b4a
Compare
gopasspw/pinentry is deprecated
toothbrush
reviewed
Aug 18, 2022
lokulin
changed the title
Add Windows Support
Update pinentry dependency and add Windows support
Aug 18, 2022
toothbrush
reviewed
Aug 18, 2022
toothbrush
approved these changes
Aug 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, i think this looks decent now. Thanks for indulging all my nitpicking! 🙏
Let's not forget to delete https://github.com/redbubble/pinentry once we're done here, too.
Co-authored-by: paul david <423357+toothbrush@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why not?
Changes:
Depends on PR #112