This repository has been archived by the owner on Feb 21, 2023. It is now read-only.
Export assumed role ARN metadata #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of our users have asked to have `yak` expose what account or environment is currently active. We've introduced an environment variable `AWS_METADATA_USER_ARN`, from which you or your script will be able to deduce which Amazon account is active, and what role you have. * aws/aws.go (EnvironmentVariables): Change parameter to be the entire sts.AssumeRoleWithSAMLOutput object, instead of just the sts.Credentials object. This gives us access to the assumed role user, too. * cmd/shim.go (shimCmd): Update aws.EnvironmentVariables call site. * format/format.go (outputFormatters): Update aws.EnvironmentVariables call site. * aws/aws_test.go (TestEnvironmentVariables): Update environment variable test to include assumed role ARN. * format/format_test.go (TestDefaultEnvCredentials): Update formatter test to include assumed role ARN. Closes #86. Co-authored-by: Michael V. <michael.vigilante@redbubble.com>
|
@rb-johnmurphy: How do you feel about this? |
rb-johnmurphy
approved these changes
Nov 26, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some of our users have asked to have
yakexpose what account orenvironment is currently active. We've introduced an environment
variable
AWS_METADATA_USER_ARN, from which you or your script willbe able to deduce which Amazon account is active, and what role you
have.
Closes #86.
Changes
sts.AssumeRoleWithSAMLOutput object, instead of just the
sts.Credentials object. This gives us access to the assumed role
user, too.
call site.
variable test to include assumed role ARN.
test to include assumed role ARN.