Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't fail to finalize observers if one fails #811

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Don't fail to finalize observers if one fails #811

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion baseplate/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -629,7 +629,10 @@ def finish(self, exc_info: Optional[_ExcInfo] = None) -> None:

"""
for observer in self.observers:
observer.on_finish(exc_info)
try:
observer.on_finish(exc_info)
except Exception:
logger.exception("Exception raised while finalizing observer")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make it so this exception includes all the details the original exception would include. I don't want things to become harder to debug because we're catching this exception.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logger.exception actually adds that information for us
https://docs.python.org/3/library/logging.html#logging.Logger.exception


# clean up reference cycles
self.context = None # type: ignore
Expand Down
Loading