Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timeout error handling #716

Merged
merged 3 commits into from
Nov 10, 2016
Merged

Fix timeout error handling #716

merged 3 commits into from
Nov 10, 2016

Commits on Oct 14, 2016

  1. Fix timeout error handling

    The main issues addressed here are:
    
    1. When renderMiddleware timesout, it will send down what ever it has
    left but it fails to close out the body and html.
    
    2. In ClientController there is a race condition between nodeArrival and
    failArrival. nodeArrival will receive a bunch of nodes since before
    failArrival is sent the nodes we have left are sent down. If failArrival
    runs an resolves `retVal` before the nodes can actually render the
    `_previouslyRender` flag will be set. Once that is set and the elements
    try to render, because `_previouslyRender` is set at the point
    `_cleanup` will be called which will wipe away everything on the page.
    sresant committed Oct 14, 2016
    Configuration menu
    Copy the full SHA
    bac5251 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2016

  1. Configuration menu
    Copy the full SHA
    c4ab537 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b991f3d View commit details
    Browse the repository at this point in the history