Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🦚 namespaced prom 🦚 #37

Merged
merged 2 commits into from
Apr 29, 2020
Merged

🦚 namespaced prom 🦚 #37

merged 2 commits into from
Apr 29, 2020

Conversation

eformat
Copy link
Contributor

@eformat eformat commented Apr 29, 2020

prometheus is namesapces .. didnt notice this until did master -> child deploy !

@eformat eformat requested review from ckavili and springdo April 29, 2020 04:23
@eformat eformat changed the title 🦚 namespaced 🦚 🦚 namespaced prom 🦚 Apr 29, 2020
springdo
springdo approved these changes Apr 29, 2020
View reviewed changes
Copy link
Contributor

@springdo springdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@springdo springdo merged commit 4fa7f51 into redhat-cop:master Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@springdo springdo springdo approved these changes

@ckavili ckavili Awaiting requested review from ckavili

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eformat @springdo