Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Alizer does not detect port if Dockerfile is not in the root directory #152

Closed
Tracked by #166
valaparthvi opened this issue Mar 24, 2023 · 2 comments · Fixed by #170
Closed
Tracked by #166

Alizer does not detect port if Dockerfile is not in the root directory #152

valaparthvi opened this issue Mar 24, 2023 · 2 comments · Fixed by #170
Assignees
Labels
area/api All issues related to component detection kind/bug Something isn't working

Comments

@valaparthvi
Copy link

➜  python-debu ls -a
.          ..         .gitignore README.md  docker     go.mod     kubernetes main.go
➜  python-debu less docker/Dockerfile
➜  python-debu odo analyze -o json
[
	{
		"devfile": "go",
		"devfileRegistry": "DefaultDevfileRegistry",
		"devfileVersion": "1.0.2",
		"name": "python-debu"
	}
]
➜  python-debu cp docker/Dockerfile .
➜  python-debu ls
Dockerfile README.md  docker     go.mod     kubernetes main.go
➜  python-debu odo analyze -o json
[
	{
		"devfile": "go",
		"devfileRegistry": "DefaultDevfileRegistry",
		"ports": [
			8081
		],
		"devfileVersion": "1.0.2",
		"name": "python-debu"
	}
]

I am taking example of Go here, but this might be relevant for other projects as well.

@thepetk thepetk self-assigned this Mar 27, 2023
@thepetk thepetk added the area/api All issues related to component detection label Mar 27, 2023
@thepetk thepetk moved this to Backlog in Sprint 234 Mar 27, 2023
@thepetk thepetk moved this from Backlog to Todo in Sprint 234 Mar 27, 2023
@jasperchui jasperchui added the kind/bug Something isn't working label Mar 31, 2023
This was referenced Apr 3, 2023
@thepetk thepetk moved this from Todo to In Progress in Sprint 234 Apr 4, 2023
@thepetk thepetk removed this from Sprint 234 Apr 4, 2023
@thepetk
Copy link
Collaborator

thepetk commented Apr 4, 2023

Update: I've set the Target date to 24 Apr 2023 for this issue. Currently investigating the issue.

@thepetk
Copy link
Collaborator

thepetk commented Apr 4, 2023

Update: I've created a PR. It checks both for root and for second-level directories it may find inside the given root path.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/api All issues related to component detection kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants