-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRW-586 add Quarkus devfile +... #223
Conversation
Failed to load devfile in OCP 4.1 instance (as in #222) but in che.openshift.io it loaded OK from https://raw.githubusercontent.com/redhat-developer/codeready-workspaces/f02980e0699a57c86672b0e60abcb5a579bc9a0a/dependencies/che-devfile-registry/devfiles/03_java11-quarkus/devfile.yaml We should probably tweak the sample project so the README.md doesn't mention JDK1.8+ (as the CRW version is for JDK11.0.6 embedded in GraalVM). Or use a different sample project? WDYT @svor ? |
crw_master_PR # 20: SUCCESS |
crw_master_PR # 21: SUCCESS |
@nickboldt
In https://github.com/quarkusio/quarkus/wiki/Migration-Guide-1.3 As I see GraalVM JDK 11 is a tech preview for now. So probably it isn't stable right now. So probably for now we have to use Java-8 and GraalVM-19.2.1 to provide native compilation |
Hmm, odd. https://github.com/quarkusio/quarkus/wiki/Migration-Guide-1.2 doesn't mention that JDK 11 is tech preview (and that's the version we have in the plugin registry). But since Stevan has said that native isn't something we NEED for 2.1, I've opened https://issues.redhat.com/browse/CRW-611 as a future work item for Che 7.10+/CRW 2.2+. I'm thinking I could remove the c++ stuff and reduce the container by a further 60MB. Or leave it because it's already over 690M :D |
@nickboldt since @svor did the upstream plugin, he's a much better reviewer than me. I can't request him, though. |
But you could have assigned it to him? |
graalvm & c/c++ stuff removed. openjdk 11 added. |
dependencies/che-devfile-registry/devfiles/03_java11-quarkus/devfile.yaml
Outdated
Show resolved
Hide resolved
Change-Id: I9f2fb6cde23ecf3eefa5d04e5b7b58cf04a5228a Signed-off-by: nickboldt <nboldt@redhat.com>
Change-Id: Iff973b43040fc0d3d2289020a23c20ac8caa3a37 Signed-off-by: nickboldt <nboldt@redhat.com>
…uarkus-java8/latest Change-Id: Ifdb15b2071c8423dc2348cd6a70f59cfe8739887 Signed-off-by: nickboldt <nboldt@redhat.com>
crw_master_PR # 35: FAILURE |
crw_master_PR # 36: FAILURE |
CRW-586 add Quarkus devfile + icon
Change-Id: I9f2fb6cde23ecf3eefa5d04e5b7b58cf04a5228a
Signed-off-by: nickboldt nboldt@redhat.com