Validate the '--no-commands' flag in the CLI

For example, it should not be possible to call it alongside '--build-command' or '--run-command', because we won't be able to know what to do.
redhat-developer · Jun 2, 2023 · ffbea2c · ffbea2c
1 parent 151712e
commit ffbea2c
Showing 1 changed file with 11 additions and 5 deletions.
diff --git a/pkg/odo/cli/dev/dev.go b/pkg/odo/cli/dev/dev.go
@@ -126,11 +126,17 @@ func (o *DevOptions) Complete(ctx context.Context, cmdline cmdline.Cmdline, args
 
 func (o *DevOptions) Validate(ctx context.Context) error {
 	devfileObj := *odocontext.GetEffectiveDevfileObj(ctx)
-	if !o.debugFlag && !libdevfile.HasRunCommand(devfileObj.Data) {
-		return clierrors.NewNoCommandInDevfileError("run")
-	}
-	if o.debugFlag && !libdevfile.HasDebugCommand(devfileObj.Data) {
-		return clierrors.NewNoCommandInDevfileError("debug")
+	if o.noCommandsFlag {
+		if o.buildCommandFlag != "" || o.runCommandFlag != "" {
+			return errors.New("--no-commands cannot be used with --build-command or --run-command")
+		}
+	} else {
+		if !o.debugFlag && !libdevfile.HasRunCommand(devfileObj.Data) {
+			return clierrors.NewNoCommandInDevfileError("run")
+		}
+		if o.debugFlag && !libdevfile.HasDebugCommand(devfileObj.Data) {
+			return clierrors.NewNoCommandInDevfileError("debug")
+		}
 	}
 
 	platform := fcontext.GetPlatform(ctx, commonflags.PlatformCluster)