Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow combination of --context with (project, app and component) flags #2443

Closed
kadel opened this issue Dec 9, 2019 · 3 comments · Fixed by #2515
Closed

Do not allow combination of --context with (project, app and component) flags #2443

kadel opened this issue Dec 9, 2019 · 3 comments · Fixed by #2515
Assignees
Labels
kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation priority/Medium Nice to have issue. Getting it done before priority changes would be great.

Comments

@kadel
Copy link
Member

kadel commented Dec 9, 2019

based on: #2387 (comment)_

It can be confusing when --context flag is used together with one or more --project --app --component flags.

We should add a check that doesn't allow the use of --context with --app or --project or --component.

@kadel
Copy link
Member Author

kadel commented Dec 9, 2019

/kind feature
/priority medium

@openshift-ci-robot openshift-ci-robot added kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation priority/Medium Nice to have issue. Getting it done before priority changes would be great. labels Dec 9, 2019
@girishramnani girishramnani self-assigned this Jan 8, 2020
@girishramnani
Copy link
Contributor

this will break alot of our tests, as currently we are using --context with --project and --app for odo create. and maybe it makes sense to have this possible for odo create because a user might want to use a specific app and a project while creating the config.yaml in the --context directory? @kadel

@kadel
Copy link
Member Author

kadel commented Jan 17, 2020

this will break alot of our tests, as currently we are using --context with --project and --app for odo create.

yes, we have to fix those tests!

and maybe it makes sense to have this possible for odo create because a user might want to use a specific app and a project while creating the config.yaml in the --context directory?

That is a good point. For odo component create it makes sense to combine --context and with --project and/or --app. But not for anything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation priority/Medium Nice to have issue. Getting it done before priority changes would be great.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants